microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.

Other

25.64k stars 804 forks source link

No weigths in JetBrains 2021 typography settings panel #481

Closed J3Rik0 closed 3 years ago

J3Rik0 commented 3 years ago

Environment

Cascadia Code version number: 2105.024
Application (with version) used to display text: Webstorm 2021.1.1
OS platform and version: Windows 10
Screen resolution (i.e. 220dpi): 4k/163dpi

Any other software?

Expected behavior

Main weight and Bold weight dropdowns under the Typography Settings section should display all of the weigths

Actual behavior

The panel shows only Roman weight

This is happening with the latest italics realease, so I'm guessing it's losing some info during the build step as it was working just fine prior to the update.

DHowett commented 3 years ago

Are you using the static fonts or the variable ones? OTF or TTF?

J3Rik0 commented 3 years ago

variable, TTF

J3Rik0 commented 3 years ago

If I use the statics I lose the ligatures (expected) and the italics (unexpected), as expected they are all separate, including the italics though

DHowett commented 3 years ago

Huh. It's not actually expected that you lose the ligatures with the static version.

J3Rik0 commented 3 years ago

Oh, my bad, I cycled through them and set it to mono without realizing it, but the italics shouldn't be separate, should they?

J3Rik0 commented 3 years ago

Yeah, the italics shouldn't be separate, looked at recursive mono statics and they don't show up separately

DHowett commented 3 years ago

The static italics being separate is was being tracked in #465 and has been fixed pending release :smile:

DHowett commented 3 years ago

@aaronbell sorry I decided to ship the non-italic variant from this build against your advice. Software engineer's ego 😓

J3Rik0 commented 3 years ago

I'm guessing there's a naming issue that's causing the weights to not show, I remember I've ran into the weights not being properly read in Windows when converting them in FontForge, had to ensure the naming pattern is consistent in order to get them properly organized. The workflow here is a bit over my hobbyist font know-how though, so I'm just drawing on my experiences 😁

aaronbell commented 3 years ago

@DHowett TBH, it seems like I need to remove the in-progress Hebrew and Arabic from the source so we can build and ship the Roman as is (with all the relevant updates / code). Otherwise we're chasing bugs that will get resolved in mid-June because everything has been updated for the new version.

I'm actually surprised the build even worked for you since the feature code has changes and, I think, requires some new ligature glyphs.

DHowett commented 3 years ago

😬 I can just prepare a build with the 2105.26 fixes for Italic's static instance naming and include the 2102 files for Regular.

aaronbell commented 3 years ago

Well...it strikes me that the STAT table needs to be updated in the Roman for things to connect properly. :/

DHowett commented 3 years ago

... crap.

aaronbell commented 3 years ago

On the plus side, we get to push out a bunch of other fixes that needed doing. :P