microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.
Other
25.64k stars 804 forks source link

Cascadia Code Upright bugfixes #482

Closed aaronbell closed 3 years ago

aaronbell commented 3 years ago

Summary of the Pull Request

A large set of bug fixes identified while working on the Italic, but solving Github reported issues.

PR Checklist

Other Cascadia Code fixes:

I do enjoy giving Dustin presents.

aaronbell commented 3 years ago

Also, remember friends, there are more fixes to come! So If you don't see yours yet, don't worry. I've got everything on the backlog :)

DHowett commented 3 years ago

I do enjoy giving Dustin presents

:smile: and I do very much appreciate the work you do here

DHowett commented 3 years ago

Closes #477 - Not specifically sure of the problem here, but suspect that it will be fixed with this - update. Closes #477 - fixed

were these both supposed to be the same number?

aaronbell commented 3 years ago

Nope. :)

DHowett commented 3 years ago

Felt ligated, might edit later.

lol

DHowett commented 3 years ago

Couple followup questions (sorry: I am out of my depth, and if my questions are annoying please let me know!)

DHowett commented 3 years ago

UGH, Okay, ignore me. Only the background one is correct.

I was looking at the diff the wrong way. 19 years of software engineering and this is what I've done to myself.

Only the background question still stands. I realized that I thought your diff deleted them, but then that clued me in that it was backwards and it is in fact adding them.

aaronbell commented 3 years ago

👍 It happens! The background can be deleted. I usually clear them out of the source on my end but must have re-added some by accident.

DHowett commented 3 years ago

In that case, it does look like the .fea and .glif files are growing support for Hebrew and Arabic (there's a lot of them added in this PR)

aaronbell commented 3 years ago

Yup! All of that stuff is disabled for now. But once we have the rest of the bits ready I’ll turn it all back on.

DHowett commented 3 years ago

Oh this is great! Will the glyphs not even be included in the final font? This is so cool

aaronbell commented 3 years ago

Nope. They’ve been set as non-exporting.