Closed aaronbell closed 3 years ago
Also, remember friends, there are more fixes to come! So If you don't see yours yet, don't worry. I've got everything on the backlog :)
I do enjoy giving Dustin presents
:smile: and I do very much appreciate the work you do here
Closes #477 - Not specifically sure of the problem here, but suspect that it will be fixed with this - update. Closes #477 - fixed
were these both supposed to be the same number?
Nope. :)
Felt ligated, might edit later.
lol
Couple followup questions (sorry: I am out of my depth, and if my questions are annoying please let me know!)
background
directory -- should we delete or keep for now?lock_latin_2
(locl.fea) which I thought would remove it~rclt.fea
~
UGH, Okay, ignore me. Only the background
one is correct.
I was looking at the diff the wrong way. 19 years of software engineering and this is what I've done to myself.
Only the background
question still stands. I realized that I thought your diff deleted them, but then that clued me in that it was backwards and it is in fact adding them.
👍 It happens! The background can be deleted. I usually clear them out of the source on my end but must have re-added some by accident.
In that case, it does look like the .fea and .glif files are growing support for Hebrew and Arabic (there's a lot of them added in this PR)
Yup! All of that stuff is disabled for now. But once we have the rest of the bits ready I’ll turn it all back on.
Oh this is great! Will the glyphs not even be included in the final font? This is so cool
Nope. They’ve been set as non-exporting.
Summary of the Pull Request
A large set of bug fixes identified while working on the Italic, but solving Github reported issues.
PR Checklist
=>>
<<=
=<<
and>>=
(the infinite arrows still work with addition of more equals)Other Cascadia Code fixes:
rclt
).I do enjoy giving Dustin presents.