microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.
Other
25.39k stars 803 forks source link

July-August 2021 Fixes #538

Closed aaronbell closed 3 years ago

aaronbell commented 3 years ago

Summary of the Pull Request

This includes two fixes:

Also: Adjusts calt feature to ensure LIG substitutions properly function under rare conditions where the ignore activate incorrectly. I thought this had already been PR'd but seems not.

For example: ===] First = becomes "equal_equal.liga", and ignore would activate on second =, blocking LIG from being substituted. If the liga form appears, LIG should appear.

Turned back on the =>> =<<, etc. ligatures as there is a glyph for them now.

In other news, I fixed my git repository.

DHowett commented 3 years ago

I cannot believe it's been since July. Okay. Is this ready to go, and does it fix more than just 500? Is there anything else we should get in before minting a 2108 copy of the font?

I ask only because we're at a terminal revision point and I forgot that this had been open for all of human history

aaronbell commented 3 years ago

Eh heh. It has been a crazy month. I think that's pretty much it for this PR. I've got some more fixes to submit at some point, but haven't had a chance to get them finalized, so those can wait.

aaronbell commented 3 years ago

Oh, just remembered one it fixes too that I snuck in related to the Hebrew language tag. Added.

DHowett commented 3 years ago

Thanks :smile: I'll merge and build this as 2108.26, and we can come back with another entry once we get that stuff ironed out that we chatted about 😏