Closed aaronbell closed 3 years ago
I cannot believe it's been since July. Okay. Is this ready to go, and does it fix more than just 500? Is there anything else we should get in before minting a 2108 copy of the font?
I ask only because we're at a terminal revision point and I forgot that this had been open for all of human history
Eh heh. It has been a crazy month. I think that's pretty much it for this PR. I've got some more fixes to submit at some point, but haven't had a chance to get them finalized, so those can wait.
Oh, just remembered one it fixes too that I snuck in related to the Hebrew language tag. Added.
Thanks :smile: I'll merge and build this as 2108.26, and we can come back with another entry once we get that stuff ironed out that we chatted about 😏
Summary of the Pull Request
This includes two fixes:
[x] Closes #500 Changes the build process to use gftools.stat instead of statmake. The issue was caused by an 'unused' italic axis in the fonts, which has been removed, but statmake gets unhappy without it there. So the process has been adjusted to a more amenable build library.
[x] Closes #552 Adds the Hebrew language tag to the Regular to ensure that Hebrew positioning works correctly.
Also: Adjusts calt feature to ensure LIG substitutions properly function under rare conditions where the
ignore
activate incorrectly. I thought this had already been PR'd but seems not.For example:
===]
First = becomes "equal_equal.liga", and ignore would activate on second =, blocking LIG from being substituted. If the liga form appears, LIG should appear.Turned back on the =>> =<<, etc. ligatures as there is a glyph for them now.
In other news, I fixed my git repository.