search

microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.
Other
25.11k stars 796 forks source link

Incorrect glyph for U+20A7 PESETA SIGN #673

Open 12Me21 opened 1 year ago

12Me21 commented 1 year ago

The current glyph for U+20A7 PESETA SIGN is a "P" with a line through it: image According to unicode, the correct glyph is the abbreviation "Pts". image

(Apparently this is a common issue due to changes made in early versions of unicode, and the addition of ₱ U+20B1 PESO SIGN (Filipino peso sign): https://en.wikipedia.org/wiki/Spanish_peseta#cite_ref-6)

I wonder if it would be best to just remove the PESETA SIGN glyph entirely? It's an obsolete currency symbol, (and it would be difficult to nicely fit "Pts" into a single character cell), so I'm not sure it's worth including.

PhMajerus commented 1 year ago

It should indeed be the "Pts" symbol. It cannot be removed because although legacy, it is required for compatibility even today.

Even if it is obsolete, the Peseta Sign is one of the characters of the original IBM PC character set, so it is required for Cascadia to properly support the MS-DOS/Windows code page 437, which is the most common 8-bit code page for legacy text-mode applications.

image

Note that even today, the code page 437 is the default OEM codepage (aka console/terminal 8-bit code page) on English-US Windows systems, making that character one of the 224 printable characters required for non-Unicode text-mode applications.

Now for the actual visual style, "Pts" might indeed make it hard to read in the terminal, and it seems IBM and Microsoft already faced this when designing the original bitmap fonts for the original IBM PC and found a solution by replacing it with a "Pt" symbol. Considering that it is obsolete and most apps using it will be using it for compatibility with the MS-DOS code page, I think we could return to the original "Pt" symbol it originally was, as you can see below:

MS-DOS code page 437: image

Original Windows Terminal font: image