microsoft / charticulator

Interactive Layout-Aware Construction of Bespoke Charts
Other
830 stars 116 forks source link

Tick format attribute ignored after saving #1056

Open wgrusznis opened 1 year ago

wgrusznis commented 1 year ago

Describe the bug The tick format attribute is ignored after saving

To Reproduce Steps to reproduce the behavior:

  1. Create a plot with a Categorical date on X axis
  2. Apply Tick format for example {%b %y}
  3. Press enter, and the preview should update with the correct Tick format
  4. Click the Save button
  5. X-axis Tick format goes back to default

Expected behavior The save button should not change attributes to default values.

Screenshots format_issue

Sample pbx format_issue_pbx.zip

zBritva commented 1 year ago

Data category is not 'temporal':

image

wgrusznis commented 1 year ago

we do want it to be categorical to be able to select a grid image

with a 'temporal' category grid is no longer available as a layout image

wgrusznis commented 1 year ago

I found a workaround. If instead of saving project, you click on "back to report" and save it in the other prompt, the Tick format is applied correctly (does not go back to default value) format_issue_workaround

wgrusznis commented 1 year ago

I would prefer to create just a formatted text column and sort it by the numerical column instead but sorting with Order by attribute is broken: https://github.com/microsoft/charticulator/issues/1052 :(