search

microsoft / charts

A Helm Chart Repository for Microsoft Projects
MIT License
30 stars 27 forks source link

Add speech-onprem helm chart for public. #1

Closed anthonsu closed 5 years ago

anthonsu commented 5 years ago

Add speech-onprem helm chart. This is a public helm chart that be used to deploy onprem speech service to kubernetes cluster.

anthonsu commented 5 years ago

Where is the speech-onprem/speech-onprem-0.1.0.tgz file? It should be included as part of this commit. Otherwise, the chart will not actually be available to pull. I would have expected to see a directory named speech-onprem and a file in this directory named speech-onprem-0.1.0.tgz unless I'm missing something?

Click Files Changed on top right, you will be able to see number 2 is listed there. After click, as a second changed file of this PR, at the bottom of page, you can find something like this:

BIN +8.38 KB repo/speech-onprem/speech-onprem-0.1.0.tgz Binary file not shown.

anthonsu commented 5 years ago

Is there another repo tracking this helm package pre-zip? It may be worthwhile to set up a CI/CD pipeline that zips these charts and creates a PR here so that we can deal with the helm files in a more source control-friendly format.

That is a good point! So far the answer is no, no other repo tracking. As to the question of pipeline, yes, we actually discussed about it several times and we are considering setting up a CI/CD pipeline for better source control. But so far we don't have it and it is in our backlog. Maybe we can start with this and have the pipeline once we have bandwidth.

To publish the helm chart, is this the only PR I need to do? From the README.md of this repo, it says "Create a branch with your work and merge it into the gh-pages branch to deploy". So once my code is merged to gh-pages, it will automatically deploy to helm hub? Is that true? Do I need to merge it into master branch as well. Sorry for this dumb question, I am new to this process.

IEvangelist commented 5 years ago

When should we expect this PR to go through? What are we waiting on?

anthonsu commented 5 years ago

When should we expect this PR to go through? What are we waiting on?

I was trying to check it in. But unfortunately I don't have WRITE ACCESS to this repo.

Could someone who has permission help merge this PR?

BrendanWalsh commented 5 years ago

Hi @Dalitso Bandamailto:Dalitso.Banda@microsoft.com,

I noticed you have checked into this repo before for spark: github.com/microsoft/charts Do you know how we can get write access?

Thanks, Brendan

From: anthonsu notifications@github.com Sent: Monday, July 1, 2019 10:20 AM To: microsoft/charts charts@noreply.github.com Cc: Brendan Walsh brwals@microsoft.com; Comment comment@noreply.github.com Subject: Re: [microsoft/charts] Add speech-onprem helm chart for public. (#1)

When should we expect this PR to go through? What are we waiting on?

I was trying to check it in. But unfortunately I don't have WRITE ACCESS to this repo.

Could someone who has permission help merge this PR?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcharts%2Fpull%2F1%3Femail_source%3Dnotifications%26email_token%3DAI7OKVIHHIUGCHO7QGEX4PTP5I4D5A5CNFSM4H4BCTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY6ZLAQ%23issuecomment-507352450&data=02%7C01%7Cbrwals%40microsoft.com%7Cc0bd129d10d14640c7d108d6fe48583b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636975983997494380&sdata=FyrzJj0tPvBIkr9lwxPNEQNYsI6%2FEeTfT7CoxniGSzI%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI7OKVOLN5RYZWUPN2OMUSLP5I4D5ANCNFSM4H4BCTDQ&data=02%7C01%7Cbrwals%40microsoft.com%7Cc0bd129d10d14640c7d108d6fe48583b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636975983997504373&sdata=DWIwv8%2B2yNd6i17KJmA%2FfB1Vd5Rb7wZuvbBhAQ7gqvU%3D&reserved=0.

BrendanWalsh commented 5 years ago

Hi,

I gave you write access to the repo.

From: Brendan Walsh brwals@microsoft.com Sent: Monday, July 1, 2019 1:32 PM To: microsoft/charts reply@reply.github.com; microsoft/charts charts@noreply.github.com; Dalitso Banda Dalitso.Banda@microsoft.com Cc: Comment comment@noreply.github.com Subject: RE: [microsoft/charts] Add speech-onprem helm chart for public. (#1)

Hi @Dalitso Bandamailto:Dalitso.Banda@microsoft.com,

I noticed you have checked into this repo before for spark: github.com/microsoft/charts Do you know how we can get write access?

Thanks, Brendan

From: anthonsu notifications@github.com<mailto:notifications@github.com> Sent: Monday, July 1, 2019 10:20 AM To: microsoft/charts charts@noreply.github.com<mailto:charts@noreply.github.com> Cc: Brendan Walsh brwals@microsoft.com<mailto:brwals@microsoft.com>; Comment comment@noreply.github.com<mailto:comment@noreply.github.com> Subject: Re: [microsoft/charts] Add speech-onprem helm chart for public. (#1)

When should we expect this PR to go through? What are we waiting on?

I was trying to check it in. But unfortunately I don't have WRITE ACCESS to this repo.

Could someone who has permission help merge this PR?

- You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcharts%2Fpull%2F1%3Femail_source%3Dnotifications%26email_token%3DAI7OKVIHHIUGCHO7QGEX4PTP5I4D5A5CNFSM4H4BCTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY6ZLAQ%23issuecomment-507352450&data=04%7C01%7CDalitso.Banda%40microsoft.com%7Ce4a849604cb7428cd5fe08d6fe49fe4e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636975991086333593%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C-1&sdata=YzhmoCyUOtyQw01%2F3d492zGYkXIwxJk0JnhcKXKMfGc%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI7OKVOLN5RYZWUPN2OMUSLP5I4D5ANCNFSM4H4BCTDQ&data=04%7C01%7CDalitso.Banda%40microsoft.com%7Ce4a849604cb7428cd5fe08d6fe49fe4e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636975991086343591%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C-1&sdata=pVvBBQ2uW6gBvEU5%2BQn1uBOH2y7hXsdGxG%2F3uw5hG%2Bk%3D&reserved=0.

dbanda commented 5 years ago

I merged the PR . I set up CI to build the zip files from repos if you populate the sources yaml file, in an attempt to automate things. If you fill in sources.yaml in master with your github repo and the link to the chart, it should generate zip files. I will work on creating automated tests for code pushed to the gh-pages branch. right now there are no tests.

anthonsu commented 5 years ago

I merged the PR . I set up CI to build the zip files from repos if you populate the sources yaml file, in an attempt to automate things. If you fill in sources.yaml in master with your github repo and the link to the chart, it should generate zip files. I will work on creating automated tests for code pushed to the gh-pages branch. right now there are no tests.

Hi @dbanda ,

Thanks for helping checking in this PR. May I ask some question about the details about this repo?

  1. to publish helm char to helm hub, the change should be merged into gh-pages branch as well? That is my understanding from README. Is that correct? May I ask why we need these two branches to make it work? From what I can see right now, it seems like master branch and gh-pages branch are out of sync a little bit. i.e. the timestamp of spark chart.

  2. maybe this question is the answer of the above one, what is the process to get chart in this repo published to helm hub? Did you create a pipeline somewhere to do that automatically?

  3. yes, like what you said in your comment above, I saw there is a sources.yaml file, which looks pulling helm chart from other GitHub repo and packaging it automatically. So to use sources.yaml, does it sync up with the source GitHub repo changes automatically? If yes, is there anywhere we can track the history of sync?

Thanks for your time to answer my questions!

IEvangelist commented 5 years ago

It's already there now... https://hub.helm.sh/charts/microsoft and https://hub.helm.sh/charts/microsoft/speech-onprem