search

microsoft / cheriot-ibex

cheriot-ibex is a RTL implementation of CHERIoT ISA based on LowRISC's Ibex core.
Apache License 2.0
73 stars 14 forks source link

Remove trailing whitespace from files #18

Closed marnovandermaas closed 6 months ago

marnovandermaas commented 11 months ago

This PR removes trailing whitespace from SystemVerilog, markdown and core files that are not in the vendor directory.

marnovandermaas commented 10 months ago

@microsoft-github-policy-service agree company="lowRISC"

marnovandermaas commented 7 months ago

I've updated this PR based on the latest main branch. It would be nice to get this merged so I do not have to redo this.

marnovandermaas commented 7 months ago

@kliuMsft would you mind having a look at this?

kliuMsft commented 7 months ago

@marnovandermaas, I do see issues with this PR.

  1. Fundamentally, I don't quite understand why trailing whitespace is an issue (or at least for verilog). Maybe you can elaborate on this?
  2. The commit touched too many files (46) of them and it's difficult to review. At this point I am really trying to stabilize the design and not introduce across-board changes.
marnovandermaas commented 6 months ago

Thanks for this message. It's a matter of taste I guess whether you are happy with trailing white-space or not. Most of the tools I use complain about trailing white-space so that is why it is noticeable for me. In the main Ibex repository trailing white-space is part of a quality lint.

However, I do appreciate that you don't want too many changes at this time. I will close this PR for now and we can revisit in when we have decided on a coding style guide.