search

microsoft / cheriot-ibex

cheriot-ibex is a RTL implementation of CHERIoT ISA based on LowRISC's Ibex core.
Apache License 2.0
73 stars 14 forks source link

Verilator lint fixes #19

Closed marnovandermaas closed 7 months ago

marnovandermaas commented 11 months ago

This PR fixes various problems picked up by browsing Verilator lint warnings. Please have a look at the individual commit messages for details of why the changes were made.

marnovandermaas commented 10 months ago

Converting this PR to draft until I fix some build issues that I am facing with Vivado.

marnovandermaas commented 10 months ago

@microsoft-github-policy-service agree company="lowRISC"

marnovandermaas commented 10 months ago

The issues I mentioned before should now be resolved. Before merging, please have a look at commit: https://github.com/microsoft/cheriot-ibex/pull/19/commits/fe2147062e1b479035ed1be2b3f3eb6cc8a8d9d7 I think this is the right approach but it does create a slight change in behavior on reset. I don't think this is a problem, but it would be good to get a second opinion.

kliuMsft commented 10 months ago

Thanks - sorry for the delayed response and I will look into it. I haven't been ignoring this but just a little swamped recently. We may have to do a manual merge this time since there are a few more updates on my side as well.

marnovandermaas commented 7 months ago

I'm converting this to draft because commit: https://github.com/microsoft/cheriot-ibex/pull/19/commits/fe2147062e1b479035ed1be2b3f3eb6cc8a8d9d7 breaks behavior of csetboundsexact.

I've now removed this commit.

marnovandermaas commented 7 months ago

I've removed two commits from this PR because of recent changes and to revert a change in behavior. This should now be ready for review.