search

microsoft / cheriot-ibex

cheriot-ibex is a RTL implementation of CHERIoT ISA based on LowRISC's Ibex core.
Apache License 2.0
73 stars 14 forks source link

Issue with illegal_reg_rv32e when RV32E #40

Closed esdatmisarian closed 1 month ago

esdatmisarian commented 1 month ago

Instruction sw x20, -1982(x3) is not seen as illegal with RV32E Waveform: issue_on_illegal_instruction_cheri

if (RV32E) begin : gen_rv32e_reg_check_active assign illegal_reg_rv32e = ((rf_raddr_a_o[4] & (alu_op_a_mux_sel_o == OP_A_REG_A)) | (rf_raddr_b_o[4] & (alu_op_b_mux_sel_o == OP_B_REG_B)) | (rf_waddr_o[4] & rf_we));

version: https://github.com/microsoft/cheriot-ibex/commit/5e4798f67417bcf87c831c56b8980af0e5d3966c

kliuMsft commented 1 month ago

Very good finding, thanks!

@marnovandermaas, this might be an issue for upstream ibex as well.

marnovandermaas commented 1 month ago

I think this is related to: https://github.com/lowRISC/ibex/issues/2178

esdatmisarian commented 1 month ago

Yes totally agree. Rgds

From: Marno van der Maas @.> Sent: Wednesday, July 17, 2024 11:03 AM To: microsoft/cheriot-ibex @.> Cc: Sedat SAYAR @.>; Author @.> Subject: Re: [microsoft/cheriot-ibex] Issue with illegal_reg_rv32e when RV32E (Issue #40)

I think this is related to: lowRISC/ibex#2178https://github.com/lowRISC/ibex/issues/2178

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/cheriot-ibex/issues/40#issuecomment-2232804319, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANX5NG2WLUIGFVYOHGYN5DLZMYXNJAVCNFSM6AAAAABK6VFRVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSHAYDIMZRHE. You are receiving this because you authored the thread.Message ID: @.**@.>>

kliuMsft commented 1 month ago

New commit a57ec46 should fix the issue, please help to verify.

esdatmisarian commented 1 month ago

Sorry for latency in feedback, it is well corrected.

From: Kunyan Liu @.> Sent: Thursday, July 18, 2024 3:01 AM To: microsoft/cheriot-ibex @.> Cc: Sedat SAYAR @.>; Author @.> Subject: Re: [microsoft/cheriot-ibex] Issue with illegal_reg_rv32e when RV32E (Issue #40)

New commit a57ec46https://github.com/microsoft/cheriot-ibex/commit/a57ec46b76c404392ad191b77f5954a6f05d2674 should fix the issue, please help to verify.

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/cheriot-ibex/issues/40#issuecomment-2234975018, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANX5NGZLEAA4VD644PQA5BLZM4HVNAVCNFSM6AAAAABK6VFRVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZUHE3TKMBRHA. You are receiving this because you authored the thread.Message ID: @.**@.>>

kliuMsft commented 1 month ago

Thanks for the confirmation. I am closing the issue then.