microsoft / cheriot-ibex

cheriot-ibex is a RTL implementation of CHERIoT ISA based on LowRISC's Ibex core.
Apache License 2.0
73 stars 14 forks source link

Change request: Separate parameters for the stack clear enable from the revoke engine enable #41

Closed ColinDBates closed 1 month ago

ColinDBates commented 1 month ago

Hi,

My understanding is the Stack Clear logic is under development/evaluation. At moment it does not seem to be possible to separately enable the Stack Clear logic and the Revocation logic. For instance in the ibex_core.sv there is the following where the CheriStkZ parameter is set by the CheriTBRE parameter on the cheri_ex instantiation. image

Also, when the CheriTBRE parameter is unset revoke engine logic does not seem to be removed from the design, but is rather disabled. It would be good if logic was optioned to be present or not by the Stack Clear and Revoke engine parameters rather than disabled. For instance in ibex_core.sv the tbre_wrapper always instantiated even if the CheriTBRE parameter is unset image

Thanks

kliuMsft commented 1 month ago

Please try the latest commit (a2f2976, hopefully that addresses the issue.