search

microsoft / clarity-apps

Repo for distributing Clarity Apps packages
MIT License
46 stars 2 forks source link

Clarity supports android only for now #16

Closed oguzydz closed 2 months ago

oguzydz commented 1 year ago

It's nice to be informed, but being warned repeatedly is annoying. I thought about removing it manually. However, it might also raise awareness for others.

image
CMLCNL commented 12 months ago

We want to use clarity for ios. Is there any information about when it will be published?

ibradwan commented 12 months ago

@CMLCNL Thanks for your interest in Clarity. We are actively working on the iOS package. If you are interested and would like to be considered for our private preview, please send us more details about your application to clarity-apps-support@microsoft.com (with "Private Preview Client" in the subject).

markymc commented 12 months ago

I also find this warning to be annoying and feel it's not necessary.

Also thanks for the info on the iOS preview. Have just applied.

nouranmaher86 commented 12 months ago

Please fill this form to join our early access list for viewing iOS SDK: https://forms.microsoft.com/r/Rdy94iErqB

obayit commented 6 months ago

Is there a way to hide this warning?

loewj-reekon commented 6 months ago

@obayit You can conditionally initialize and call Clarity functions using Platform.OS === 'android'.

ibradwan commented 4 months ago

iOS support has been released.

IanLukeFinley commented 4 months ago

I note however that, as of version 3.0.0, which I believe is the latest, the SupportedPlatforms in index.ts is still 'android' only, so the error appears, even when enableIOS_experimental is true in the config. image

ibradwan commented 4 months ago

Thanks @IanLukeFinley for reporting that. @amralaa-MSFT Can you please double check?

amralaa-MSFT commented 4 months ago

@IanLukeFinley the ios value gets added in runtime to SupportedPlatforms only after initialize() is called with enableIOS_experimental === true. This means that calling any other APIs such as setCurrentScreenName() would cause this warning to show up because ios value hasn't been added yet.

Could you please double check that your app doesn't use other Clarity APIs before initialize() is called? If that's the case, can you tell us where you call initialize()?

IanLukeFinley commented 4 months ago

Yes, the issue seems to be the NavigationContainer in our App.tsx, which calls setCurrentScreenName before Initialize (which happens in our MainWrapper.tsx, a step down), when structured as you lay out in the readme. By removing the call for setCurrentScreenName from onReady, the flow happens in the correct order.

ibradwan commented 2 months ago

This issue has been fixed in a recent release.