search

microsoft / clarity-js

This library has moved and is now available at
https://github.com/microsoft/clarity
Other
220 stars 32 forks source link

vNextBeta6: Type refactoring and addressing known issues #149

Closed sarveshnagpal closed 5 years ago

sarveshnagpal commented 5 years ago
  1. Strongly typing various event types to assist with analytics
  2. Breaking payload into multiple streams - one per event type
  3. Using discriminated unions to simplify types
  4. Dropping "I" from interfaces as per guidelines by Typescript.
  5. Stop sending redundant document information back to server
  6. Simplifying metrics and folding them into Data and sending them as regular events
  7. Dropping title from the Event.Page for security
toby-walker commented 5 years ago 
        case Event.RightClick:

Would prefer to just have a single Click event with properties indicating what kind it is.

Refers to: decode/clarity.ts:54 in d55bcaa. [](commit_id = d55bcaaccf1ab80099e90366fd3c124e75910820, deletion_comment = False)

toby-walker commented 5 years ago

Cod you please tag the commit with the version after you merge it so that's easier to start tracking this and go from version to commit?

toby-walker commented 5 years ago 
            resources.push({ tag, url: attributes["href"]});

Can you add the relationship (rel attribute) to this event? For future use. Could be encoded as int for closed vocacbulary.

Refers to: decode/layout.ts:168 in d55bcaa. [](commit_id = d55bcaaccf1ab80099e90366fd3c124e75910820, deletion_comment = False)

toby-walker commented 5 years ago 
        xhr.send(data);

Important: Add retry. Send gif or something when error happens. #Closed

Refers to: src/data/upload.ts:74 in d55bcaa. [](commit_id = d55bcaaccf1ab80099e90366fd3c124e75910820, deletion_comment = False)