search

microsoft / clarity-js

This library has moved and is now available at
https://github.com/microsoft/clarity
Other
220 stars 32 forks source link

Bug fixes and improvements in v1.0.0-beta.18 #166

Closed sarveshnagpal closed 4 years ago

sarveshnagpal commented 4 years ago

This is work in progress. Sending out first draft for early review. This is a significant change. I'll follow up later with few more changes, especially around fixing network data bug fixes from b16.

toby-walker commented 4 years ago

export interface MetricEvent extends PartialEvent { data: MetricData; }

Aside: There's a standard way for declaring this kind of thing using templates.

PageEvent extends PartialEvent

Where PartialEvent is defined as interface { data:T }

Not sure about the exact TypeScript syntax. #Pending

Refers to: types/decode/data.d.ts:5 in fc920a3. [](commit_id = fc920a336e55554fa7250cf07c6141d9c2bc8b91, deletion_comment = False)

sarveshnagpal commented 4 years ago

export interface MetricEvent extends PartialEvent { data: MetricData; }

Thanks, I will look it up but probably as part of the next change.

In reply to: 576374275 [](ancestors = 576374275)

Refers to: types/decode/data.d.ts:5 in fc920a3. [](commit_id = fc920a336e55554fa7250cf07c6141d9c2bc8b91, deletion_comment = False)