search

microsoft / clarity

A behavioral analytics library that uses dom mutations and user interactions to generate aggregated insights.
https://clarity.microsoft.com
MIT License
2.09k stars 208 forks source link

Update from 0.7.21 to 0.7.22 has breaking changes #542

Closed sjorsrijsdam closed 6 months ago

sjorsrijsdam commented 7 months ago

Clarity's latest update introduces code that empties out <noscript> tags. Our sites make use of the <noscript> tag for progressive enhancement purposes. I guess you can see where this is going 😅 . By blindly assuming <noscript> tags are of no use and emptying them Clarity broke our sites. I have tracked it down to this commit https://github.com/microsoft/clarity/commit/d934c35e538bbdbd791697e1f450e1ea8ed278b7. In order to get our sites working again we've removed Clarity for now.

I would strongly urge you to not shotgun modify code you do not own and have no knowledge or context of.

dlutsyk commented 6 months ago

We are facing the same problem here :)

WilbertWalrus commented 6 months ago

By blindly assuming <noscript> tags are of no use and emptying them Clarity broke our sites.

https://github.com/microsoft/clarity/blob/d934c35e538bbdbd791697e1f450e1ea8ed278b7/packages/clarity-js/src/layout/node.ts#L110-L113

This is so careless 😞

AbdelrhmanMagdy commented 6 months ago

This issue is Fixed in v0.7.23