microsoft / cobalt

Infrastructure turn-key solution for app service workloads
MIT License
115 stars 78 forks source link

[ ASE ] Keyvault URI and Docker Keyvault URI not present in unauth App Settings #279

Closed TechnicallyWilliams closed 5 years ago

TechnicallyWilliams commented 5 years ago

Background

Webhooks are expected to read keyvault uris from app settings in order to obtain secrets for authenticating into docker for image pulls. Currently, app settings is missing a value for keyvault_uri and the value for docker keyvault uri is incorrect.

Description

As a user, I'd like app settings for my unauthenticated app services to include the correct keyvault uris.

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

Resources

image

Indexing into the structure of the keyvault secrets output shown in the above screenshot throws the following error: image

Screenshot of the correct app settings: image

App-Settings JSON: image

Tasks

Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic. Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)

Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)

Assignee should break down work into tasks here