microsoft / cobalt

Infrastructure turn-key solution for app service workloads
MIT License
116 stars 78 forks source link

Key Vault Secret ID is not updated if new version is created #287

Closed TechnicallyWilliams closed 5 years ago

TechnicallyWilliams commented 5 years ago

Background

Currently, the arm provider will not correctly output key vault secret ids into App Service's app settings when key vault secrets are versioned. A screenshot of the error is attached.

Description

As a user, I'd like my app settings to be update-able with versioned key vault secret ids.

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

Resources

Tasks

Assignee should break down work into tasks here

TechnicallyWilliams commented 5 years ago

The following PR resolved this issue: PR (https://github.com/microsoft/cobalt/pull/278) "Fixes secret handling in app settings for ACR access "