microsoft / cobalt

Infrastructure turn-key solution for app service workloads
MIT License
116 stars 78 forks source link

Remove unused app service variable values 'repository' and 'dockerfile' #312

Closed awkwardindustries closed 4 years ago

awkwardindustries commented 4 years ago

All Submissions:


What is the current behavior?


Currently, the as-isolated-service-single-region template assigns and expects the fields repository and dockerfile; however, these are not used by the app services that are created. The result is a confusing addition of required but unused variables.

Issue Number: Closes #209

What is the new behavior?


Behavior of the deployment does not change; however removal of the unused variables helps clarify usage.

Does this introduce a breaking change?


Any relevant logs, error output, etc?


N/A

Other information


awkwardindustries commented 4 years ago

Appears to be failing due to issues corrected in PR #303. Will rebase/merge after successful merge.