Remove ACR Webhooks; Do not manage container settings via Terraform

nmiodice commented 4 years ago

All Submissions:

[YES] Have you followed the guidelines in our Contributing document?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[YES] I have updated the documentation accordingly.
[YES] I have added tests to cover my changes.
[YES] All new and existing tests passed.
[YES] My code follows the code style of this project.
[YES] I ran lint checks locally prior to submission.
[YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?

ACR Webhooks are determined to be unsuitable for the deployment strategy that we want to use. This is detailed in https://github.com/microsoft/cobalt/issues/316.

This change removes the ACR webhooks and also prevents Terraform from changing the container settings for existing webapps.

Issue Number: https://github.com/microsoft/cobalt/issues/316

What is the new behavior?

az-hello-world is unchanged
az-service-single-region deploys containerized webapp. The Image is specified after the initial deployment and subsequent terraform deployments will not try to override the container settings. No ACR webhook is configured.
az-isolated-service-single-region deploys containerized webapp. No image is specified after the initial deployment and subsequent terraform deployments will not try to override the container settings. No ACR webhook is configured.

Does this introduce a breaking change?

[YES] ACR Pull no longer works

Any relevant logs, error output, etc?

ThePhen commented 4 years ago

Aha! So this was letting the .terraform.d folder hang around between jobs/stages, @nmiodice?

nmiodice commented 4 years ago

@ThePhen That was a "try this to see if it works" approach that I ended up backing out. We actually want to keep the .terraform folder around as it includes some helpful things. See some more commentary here if you are interested

microsoft / cobalt