[YES] Have you followed the guidelines in our Contributing document?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[NA] I have updated the documentation accordingly.
[NA] I have added tests to cover my changes.
[NA] All new and existing tests passed.
[YES] My code follows the code style of this project.
[NA] I ran lint checks locally prior to submission.
[YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
What is the current behavior?
Individual PRs will compete for the same resource groups as the master branch deployment. This is a frequent immediate cause for many of the CD failures that we see in the PR checks for otherwise correct code. This problem is expected to become a more serious issue once a custom build agent is in use (with parallel builds).
Issue Number: #311
What is the new behavior?
When CI/CD checks are performed on a Pull Request, the PR number is appended to the Terraform Workspace Name. This ensures that the deployment of the PR that occurs during the checks will not race with other PR checks or with the main merge stream back to master.
Master merges should continue to deploy as before, without an appended number in the workspace name.
As a [new] final step in the PR process, developers need to be mindful about tearing down these temporary workspaces once their code merges to master, in order to keep resource expenditure from spiraling.
All Submissions:
What is the current behavior?
Individual PRs will compete for the same resource groups as the master branch deployment. This is a frequent immediate cause for many of the CD failures that we see in the PR checks for otherwise correct code. This problem is expected to become a more serious issue once a custom build agent is in use (with parallel builds).
Issue Number: #311
What is the new behavior?
Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information