[x] Have you followed the guidelines in our Contributing document?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[NA] I have updated the documentation accordingly. Issue exists to update process documentation.
[NA] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My code follows the code style of this project.
[x] I ran lint checks locally prior to submission.
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
What is the current behavior?
Currently when using the version 'n' go process, external script files must also be pulled and included in the build artifact for usage by the pipeline. This introduces complexity of requiring a secondary Git repo from which to pull the scripts and/or authentication issues if the repo is not public. Although it can be worked around with git commands in an inline script task, inlining all of the external scripts would allow us to remove this dependency.
Issue Number: Closes #298
What is the new behavior?
All scripts have been rewritten as single task YAML template files. These can be reused across the pipelines, and when referred to as a repository reference, they will automatically be included by Azure DevOps and will not need to be downloaded as a separate process.
This PR closes out the final cleanup, removing an unused commons.sh and updating the azure-pipelines-app.yml template file to remove the inline script task that used git clone to pull down the external scripts to be included as part of the build artifact.
All Submissions:
What is the current behavior?
Currently when using the version 'n' go process, external script files must also be pulled and included in the build artifact for usage by the pipeline. This introduces complexity of requiring a secondary Git repo from which to pull the scripts and/or authentication issues if the repo is not public. Although it can be worked around with
gitcommands in an inline script task, inlining all of the external scripts would allow us to remove this dependency.Issue Number: Closes #298
What is the new behavior?
All scripts have been rewritten as single task YAML template files. These can be reused across the pipelines, and when referred to as a repository reference, they will automatically be included by Azure DevOps and will not need to be downloaded as a separate process.
This PR closes out the final cleanup, removing an unused
commons.shand updating theazure-pipelines-app.ymltemplate file to remove the inline script task that usedgit cloneto pull down the external scripts to be included as part of the build artifact.Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information