microsoft / cobalt

Infrastructure turn-key solution for app service workloads
MIT License
116 stars 78 forks source link

Enable white-listing features & tests and self-hosted agents #350

Closed ThePhen closed 4 years ago

ThePhen commented 4 years ago

All Submissions:


What is the current behavior?


Resolves Issue Number: #339 and #341

What is the new behavior?


Does this introduce a breaking change?


ThePhen commented 4 years ago

@erikschlegel has pointed out that some solid integration tests, which check that the IP While Lists are as expected at Integration Test-time, are needed, and that's a great point.

I'd suggest that such test get written as a follow-on tasks, given that the team chose the unit vs. integration test strategy for this PR, and this PR is blocking some other work.

I do believe I know what needs to be written to enact the integration test that Erik's calling out.