Closed ThePhen closed 4 years ago
@erikschlegel has pointed out that some solid integration tests, which check that the IP While Lists are as expected at Integration Test-time, are needed, and that's a great point.
I'd suggest that such test get written as a follow-on tasks, given that the team chose the unit vs. integration test strategy for this PR, and this PR is blocking some other work.
I do believe I know what needs to be written to enact the integration test that Erik's calling out.
All Submissions:
What is the current behavior?
Resolves Issue Number: #339 and #341
What is the new behavior?
resource_ip_whitelist
must be provided by users (e.g. by settingTF_VAR_resource_ip_whitelist to
["x.x.x.x/32"], or via
*.tfvars`, etc). Build pipelines fail with a clear error, if a value is not provided.verifyIPWhitelistForACR
tests at .../acr.go and .../keyvault.gowere removed, in favor of the new IP White List testing in
az-isolated-service-single-region/tests/unit/unit_test.go`)Does this introduce a breaking change?