microsoft / cobalt

Infrastructure turn-key solution for app service workloads
MIT License
116 stars 78 forks source link

ISO template users can optionally provide a `TF_VAR_resource_ip_whitelist` env-var to control the VNET white-list #356

Closed ThePhen closed 4 years ago

ThePhen commented 4 years ago

All Submissions:


What is the current behavior?


ISO template users must provide whitelist IP/CIDR input via the infra/templates/az-isolated-service-single-region/terraform.tfvars file (and thus check-in a change to that file to account for their specific self-hosted build agents)

Resolves Issue Number #341

What is the new behavior?


ISO template users can optionally provide a TF_VAR_resource_ip_whitelist environment variable (via many means, including Az Pipeline Variable Groups) to control the whitelist.

Users that do not use the new, optional env var will see the same behavior as before.

ThePhen commented 4 years ago

@nmiodice gave me some ideas. I'll close thiss, then re-open, later today, when I'ver tried his suggestions.