microsoft / cobalt

Infrastructure turn-key solution for app service workloads
MIT License
116 stars 78 forks source link

IP White List integration tests for ISO example template #359

Open ThePhen opened 4 years ago

ThePhen commented 4 years ago

Description

*As an ISO template engineer, I'd like to have integration tests that verify IP White List configuration is enacted on AZ resources.

As of this writing, there are unit tests that very that terraform plans reflect IP white list configuration settings, but they do not actually test that terraform apply has enacted such config upon Key Vaults and ACRs. Integration tests could cover this.

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

See PR #350 for more, especially this comment.