microsoft / code-with-engineering-playbook

This is the playbook for "code-with" customer or partner engagements

https://microsoft.github.io/code-with-engineering-playbook/

Creative Commons Attribution 4.0 International

2.15k stars 567 forks source link

Add a new page with guidance on how to write UI/e2e tests for a Teams application #1038

Closed adinastoll closed 2 months ago

adinastoll commented 3 months ago

Pull Request Template

What are you trying to address

Contributing with a new guidance based on previous engagement on how to write UI tests for a custom Teams application.

Checklist

[x] Changes follow the repo structure and land in the appropriate folder and section
[x] No confidential information
[x] No duplicated content
[x] Labeled appropriately
[x] Added 2 reviewers
[x] No lint errors
[x] No lint check errors related to your changes

Note: You may see link check errors on pages you have not touched. This is normal, and due to either broken links or sites that reject link checker bots. The reviewer will help you get to a green state on these.

adinastoll commented 3 months ago

@benjguin Thank you for the review! :) Based on your suggestion, I added a sub-chapter in Overview to highlight the learnings. Thanks for the suggestion!

I'll keep the step by steps until further feedback from Playbook maintainers, though your point is really valid. I might keep just the aspects which are relevant to Teams (such as choosing a device with Play Store enabled, else Teams can't be installed etc)

adinastoll commented 3 months ago

Great content... I have added some language suggestions and general formatting

Thank you @TessFerrandez for your review! I have addressed the comments. :)

TessFerrandez commented 2 months ago

@shiranr or @tompaana could one of you review this?

shiranr commented 2 months ago

Great content! thank you for contributing :) Left couple of comments.

adinastoll commented 2 months ago

Great content! thank you for contributing :) Left couple of comments.

Thank you for reviewing it, @shiranr. I have addressed all your comments! Please have a look.