search

microsoft / codetour

VS Code extension that allows you to record and play back guided tours of codebases, directly within the editor.
https://aka.ms/codetour
MIT License
4.36k stars 113 forks source link

Previewing a step after editing it (without clicking the save button) erases changes #138

Closed dsschnau closed 3 years ago

dsschnau commented 3 years ago
  1. Edit a CodeTour step
  2. Click the 'Preview Tour' button in the step window
  3. See that the edits aren't rendered
  4. Go back to 'edit step'
  5. Changes from step 1 are gone
gracegtaylor commented 3 years ago

Thank you for this suggestion. I can see that it would be annoying to lose your work. We will look into prioritizing this issue.

lostintangent commented 3 years ago

Upon investigation, there seems to be a bug in VS Code that would prevent us from saving the contents, unless you click one of the "big buttons" beneath the text box. That said, if we address https://github.com/microsoft/codetour/issues/140, would that be sufficient to start? Then, you could simply save your step and enter preview mode, as opposed to needing to enter preview mode and have it save your step?

gracegtaylor commented 3 years ago

That can be a great start. Anything we can do to prevent loss of work would be helpful.

lostintangent commented 3 years ago

140 is now addressed, and so that should help mitigate this issue a bit? Unfortunately, I'm not able to resolve this further without an ask on VS Code.

lostintangent commented 3 years ago

I'm going to close this as a duplicate of #110.