microsoft / codetour

VS Code extension that allows you to record and play back guided tours of codebases, directly within the editor.
https://aka.ms/codetour
MIT License
4.36k stars 113 forks source link

JSON schema for `view` is too restrictive #279

Closed shati-patel closed 1 year ago

shati-patel commented 1 year ago

The schema for the view property is an enum with certain "well known" views. However, the implementation allows you to use any view, including a view from a custom extension.

I suspect the enum in the schema is wrong here, since the description ("The ID (e.g. gistpad.gists) that this step is associated with.") also suggests that custom views should be permitted 🖼️


For example, we're using this in our CodeQL code tour to focus on specific views from the CodeQL extension. This works fine, but we're getting a schema validation error 😢
image