Update schema for `view` to match code implementation

microsoft / codetour

VS Code extension that allows you to record and play back guided tours of codebases, directly within the editor.

https://aka.ms/codetour

MIT License

4.36k stars 113 forks source link

Update schema for `view` to match code implementation #280

Closed shati-patel closed 1 year ago

shati-patel commented 1 year ago

Fixes https://github.com/microsoft/codetour/issues/279.

You can link a tour step to any view (as implemented here in the code). However, the schema seemed too restrictive and only allowed a fixed list of views. I've added more information to the linked issue! 🙇🏽‍♀️

This PR expands the schema to allow anything in that enum as well as any custom view. Alternative suggestion: we could delete the enum altogether, but that would make those "well-known" views less visible 💜

shati-patel commented 1 year ago

@microsoft-github-policy-service agree