microsoft / coe-starter-kit

Other
743 stars 219 forks source link

[CoE Starter Kit - BUG] Compliance mails for requested only sent once #4314

Open johnravas opened 1 year ago

johnravas commented 1 year ago

Describe the issue

I am setting up the compliance "missing details" notification for a single environment, so I can test the experience - before opening it up to all of my makers. I have configured the environment variables to support a simple example in a single environment. When the Admin | Compliance Detail request v3 flow runs, it runs successfully, but I don't receive any kind of notification.

I originally posted about this in the Discussions area so there are more details here

When I review the run of the flow, it shows that the environment is being processed, it shows that it sees the app that I should receive notification for and it sees that there are 22 sessions in the last 30 days (I set the threshold to 5). In looking deeper in the flow these actions are not running: image image image

During our discussion conversation, we established that the supporting flows were not enabled. They are now and did not run at all this week.

Let me know what additional info I can provide.

Expected Behavior

Expect to receive notification that I need to supply more details on this app

What solution are you experiencing the issue with?

Core

What solution version are you using?

3.53

What app or flow are you having the issue with?

Admin | Compliance details request v3

Steps To Reproduce

No response

Anything else?

No response

AB#1076

Jenefer-Monroe commented 1 year ago

That failure is caught, its because we sometimes get the session count another way, for you we correctly get it as 22. The next thing to check is to look into the condition Condition: Audit apps that are broadly shared or admin has requested audit Can you open that and see which way it goes? image

johnravas commented 1 year ago

Here is where the goes after that action: image

Let me know if you need more information.

Jenefer-Monroe commented 1 year ago

Sorry for the delay. For this condition, I presume its not going in to the yes path, is that correct? image

The mail only gets sent once here when the object is initially set to Requested. This seems like a mistake to me and we should resend. Please confirm and if so I'll mark as a bug to consider. image

johnravas commented 1 year ago

Hi Jenefer - here is a screenshot of the flow leading up to that action: image Let me know if you need anything else.

Jenefer-Monroe commented 1 year ago

Yes thats what I thought, so basically once it updates the object to "requested", then it wont do it again, and therefore never send another mail. Thanks for investigating. Marking as a bug to address.

If you want to force out mails for everyone, you would want to unmark all the apps currently marked as Requested, then on the next run, now that the email flow is on, you should get the mails. image

johnravas commented 1 year ago

Thanks for the info Jenefer. Here is the current state of the app:

image

The thing is I never received even the initial email for this app. I can clear this field and force a run of the flow to see if that generates even the first email. Does that make sense?

Jenefer-Monroe commented 1 year ago

Yes I think it got set to Requested before we turned on the email flow. Clear that field, then you should see the mail next run.

johnravas commented 1 year ago

Ah yes. Thanks for the reminder on that Jenefer. Going to clear the field and test it out. Thanks for the assistance.

johnravas commented 1 year ago

Tested and message received!! Thanks for the assistance.

Jenefer-Monroe commented 1 year ago

great, we'll keep this open as a bug, have tagged it up for triage.

johnravas commented 1 year ago

Jenefer - looks like the instructions listed in the Developer Compliance Center app for updating the App Description are out of date. They indicate: image It should really indicate something like Edit the app, click on the Settings (gear) icon. Under the General tab, complete the Description field

We can provide training for our users on this different. Just thought you would want to know. I am sure this sequence was correct when the app was initially built.

Jenefer-Monroe commented 1 year ago

Thank you, would you mind posting a separate bug for this? Then I will tag that to the same resource to fix up with the other bugs.

johnravas commented 1 year ago

Will do. Thanks Jenefer!!