microsoft / coe-starter-kit

Other
743 stars 219 forks source link

[CoE Starter Kit - QUESTION] Allow kit to have a non-english preferred languange for all mails #6077

Open federicoruiz opened 1 year ago

federicoruiz commented 1 year ago

Does this question already exist in our backlog?

What is your question?

In our tenant, we only manage one language (Spanish) and we realized after translating and launching the governance flows that they were being sent in English because the user did not have a language set in Azure AD.

image Check for user preferred language in Azure AD image Set en-US if the user didn't have the property.

In other words, these flows first check the user's preferred language in AD. If it is empty, it sets the preferred language variable to en-US and ignores the Preferred Language environment variable.

Now, if we want the messages to be sent with the preferred language set in the environment variable, we would have to modify the logic of ALL flows to obey the preferred language set in the environment or modify all English language messages to Spanish.

Edit: The problem is that in our case, all of our users didnt have set the prefered language in AD

¿Which option do you recommend for addressing this?

Thanks, a lot. Regards Ruiz Federico

What solution are you experiencing the issue with?

Governance

What solution version are you using?

July 2023

What app or flow are you having the issue with?

No response

What method are you using to get inventory and telemetry?

Cloud flows

AB#1720

Jenefer-Monroe commented 1 year ago

We dont have a concept of preferred language for the kit. We default to english always as thats the only thing we ship.

I could add this as a feature but I wouldnt expect us to be able to fund anytime soon due to competing prioritites. So if you'd like to use localized mails for now you would need to:

  1. add localized versions of all mails (this would be needed even with our feature)
  2. Add a prefered language in AD for your users.

And we can put this on our backlog.

federicoruiz commented 1 year ago

Hi @Jenefer-Monroe thanks for your response!

Now I understand the use of the variable "Admin Email Preferred language", because we tested all flows in a non-production environment, and all the emails/approvals were in Spanish. That confused us and we expected the same behavior in production. We've seen that other flows uses the property preferred language set in the Makers Table too.

Thanks,

Jenefer-Monroe commented 1 year ago

Oh I see the confusion. That hadnt occurred to me as somethign that would happen. So sorry about that! I've put this on the backlog now so hopefully we can fund.

hbazerbashi commented 9 months ago

Hi, I have a similar issue, and I'm slightly confused. What determines the outgoing email language? Is it Azure AD's preferred language property? It seems to be uneditable in Azure AD.