microsoft / coe-starter-kit

Other
751 stars 221 forks source link

[CoE Starter Kit - BUG] Admin | Audit Logs | Sync Audit Logs (V2) - secret value cannot be null #7130

Closed shrutibahl closed 11 months ago

shrutibahl commented 11 months ago

Does this bug already exist in our backlog?

Describe the issue

I am getting the following error in the Get Azure Secret step of the Admin | Audit Logs | Sync Audit Logs (v2) flow.

image

How can I get this error to work?

Also, is this an issue or a non-issue?

image

Please let me know.

Expected Behavior

I am not using Azure Vault so this field is ok to be blank and the flow should not throw this error.

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.16

What app or flow are you having the issue with?

Admin | Audit Logs | Sync Audit Logs (V2) flow

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

Run the Admin | Audit Logs | Sync Audit Logs (V2) flow

Anything else?

I have checked the client Secret and other variables multiple times and they seem to be fine.

AB#883

Jenefer-Monroe commented 11 months ago

You are not using Azure Key Vault so this failure is expected and caught. Note that flow always shows the first failure even if its a caught failure, so you need to go further down in the flow to find the flow actually terminates (fails) the flow

image

Jenefer-Monroe commented 11 months ago

You do seem to have found the correct terminating failure which states that the subscription is not enabled. I believe that means you missed this steps of the setup instructions:

Start a subscription to audit log content

shrutibahl commented 11 months ago

So, I do have the app registration, API permissions etc. added. When I run the Admin | Audit Logs | Office 365 Management API Subscription flow, the StartSubscription step shows the status code 400. Is this a problem? Per the instructions this just means that the service has been started and I could just ignore it.

image

image

shrutibahl commented 11 months ago

Also, Question - Is it ok to import the Nurture solution without waiting for this to get resolved?

shrutibahl commented 11 months ago

The error it's throwing is Tenant does not exist. image

But I checked and verified that the tenant ID is correct. image

shrutibahl commented 11 months ago

Any update on this? I'm stuck on this step.

Jenefer-Monroe commented 11 months ago

Hello, please note the CoE Starter Kit is an unsupported set of templates: https://docs.microsoft.com/en-us/power-platform/guidance/coe/feedback-support

We do best effort to assist our GitHub customers but we do not have SLA.

Thank you for your patience

Jenefer-Monroe commented 11 months ago

It sounds like you did not fill in the tenant id env variable. Typically this means that you did not use the Setup Wizard to setup or install. Its highly recommended that you use the Setup Wizard to walk you through setup and upgrades. It will ensure all the new flows are turned on in the correct order, trigger things like population of the bookmarks screen and do other cleanup steps needed. You should do this both for upgrades and clean installs. To use it, first perform the import of the solution install or upgrade manually, then boot the app and walk through the screens. image image

Jenefer-Monroe commented 11 months ago

You can update it now though using the CoE Admin Command Center. After you fill it you will want to turn this flow off and back on in order to ensure it takes the new env var value. image

shrutibahl commented 11 months ago

But I already have the tenant ID populated

image

Jenefer-Monroe commented 11 months ago

ok lets hop back up to the beginning to see if we can figure this out.

  1. Go to your app registration and validate that you have the correct API permissions. Note that it requires application permissions not delegated. image

  2. Validate that you have entered all the env variables correctly image

  3. Turn the flows off and back on. Sometimes env vars get stuck in them with old values

shrutibahl commented 11 months ago

Ok I just followed through all the steps in the CoE Setup and Upgrade Wizard app and was able to get that to work. Thank you for all your help.

P.S. - I didn't see any mention of this app in the MS Learn documents that I followed https://learn.microsoft.com/en-us/power-platform/guidance/coe/setup-core-components Is there any other documentation for step-by-step guidance of CoE components installation?

Jenefer-Monroe commented 11 months ago

Wonderful news! The setup instructions for the audit logs are here: Collect audit logs using an HTTP action. Let me know if that was what you were requesting or not.

Jenefer-Monroe commented 11 months ago

closing out as no further action for starter kit team