search

microsoft / coe-starter-kit

Other
747 stars 219 forks source link

[ALM Accelerator - BUG]: UseDeploymentSettingsPlaceholders variable not working #7212

Open rhulshof opened 10 months ago

rhulshof commented 10 months ago

Describe the issue

When setting UseDeploymentSettingsPlaceholders to False, ALM Accelerator still uses Placeholders in combination with Pipeline Variables to store the values. I have tried this using a Pipeline Variable as well as using the alm-accelerator-variable-group. It keeps neglecting the setting.

Expected Behavior

ALM Accelerator directly writes the deployment configuration values into the customDeploymentSettings.json and deploymentSettings.json files in the Repository.

What component are you experiencing the issue with?

ALM Accelerator Pipelines

What solution version are you using?

1.0.20230606.1

Steps To Reproduce

  1. Go to Azure DevOps
  2. Go to Pipelines
  3. Go to Library
  4. Go to alm-accelerator-variable-group
  5. Add Variable Name UseDeploymentSettingsPlaceholders and set Value to False
  6. Go to ALM Accelerator
  7. Run Commit Solution
  8. Wait for export-solution-to-git Pipeline to complete
  9. Go to Repos -> Files -> [SOLUTIONNAME] -> Go to config -> Go to [ENV-NAME]
  10. Select file deploymentSettings.json
  11. Check if file content show Placeholders or display the desired Configuration Values directly

Anything else?

No response

AB#1627

RajeevPentyala commented 10 months ago

@rhulshof I could not replicate the issue you mentioned on my end. I just want to ensure the following points.

rhulshof commented 10 months ago

Confirmed. UseDeploymentSettingsPlaceholders is not registered in any Pipeline Variable itself. It is only listed in the alm-accelerator-variable-group. The access to this alm-accelerator-variable-group is granted correctly.

image

image

Even after running a Commit, the deploymentSettings keep using the placeholders instead of adding the values inline:

image

RajeevPentyala commented 9 months ago

@rhulshof I wasn't able to reproduce the issue. I'd like to schedule a troubleshooting session. Please reach out to me at rajeevpe(at)microsoft(dot)com?