microsoft / coe-starter-kit

Other
747 stars 220 forks source link

[CoE Starter Kit - QUESTION] Condition details for Inactive flows #7568

Closed rimoism closed 8 months ago

rimoism commented 8 months ago

Does this question already exist in our backlog?

What is your question?

The following document states that the conditions for an inactive flow are that there is no flow editing for a certain period of time (default 180 days) and the status is Turn OFF. Admin | Inactivity notifications v2 (Start Approval for Flows)

I think that Turn OFF refers to the flow status as shown below. image

Q. Is my understanding of the meaning of "Turn OFF" correct?

On the other hand, the filter that retrieves the list of inactive flows has a condition where status ≠ Stopped. image

Q. I think the correct code for this condition is "admin_flowstate ne 'Started'" or "admin_flowstate eq 'Stopped'", is that correct?

What solution are you experiencing the issue with?

Governance

What solution version are you using?

January 2024

What app or flow are you having the issue with?

Admin | Inactivity notifications v2 (Start Approval for Flows)

What method are you using to get inventory and telemetry?

Cloud flows

AB#2171

RahulBojji commented 8 months ago

Yes, whatever you are understanding the process is correct. You can make an unmanaged layer for now to remove this filter if you would like and that we will be making this configurable when we redo the feature.

rimoism commented 8 months ago

Yes, whatever you are understanding the process is correct. You can make an unmanaged layer for now to remove this filter if you would like and that we will be making this configurable when we redo the feature.

Thank you for your reply. Please tell me why the condition implemented in the actual flow is status ≠ Stopped (status = Started or status = Suspended) even though the reference says TurnOFF.

RahulBojji commented 8 months ago

status not equal to stopped is same as status = started or status= suspended. It retrieves both started flows and suspended flows.

rimoism commented 8 months ago

I believe that flows with a status of "Started" are generally active. I feel strange that the default condition is like that.

RahulBojji commented 8 months ago

As mentioned above, feel free to make an unmanaged change as we will be redoing this feature to make it configurable Thanks

Jenefer-Monroe commented 8 months ago

closing out as no further action for starter kit team