microsoft / coe-starter-kit

Other
743 stars 219 forks source link

environment auto approve function not working for maker app #8437

Open KrishanKumar1999 opened 3 months ago

KrishanKumar1999 commented 3 months ago

Does this question already exist in our backlog?

What is your question?

Issue: After creating an environment through Maker app the environments are showing in Pending state. I want to get it auto approved.

Version of COE: Its happening after migrating to 4.29.

What solution are you experiencing the issue with?

None

What solution version are you using?

4.29

What app or flow are you having the issue with?

No response

What method are you using to get inventory and telemetry?

None

AB#3510

Jenefer-Monroe commented 3 months ago

I'm unsure what you mean by auto-approve. Can you please clarify? To my knowledge you have to explicitly approve these through the CoE Admin Environment Request app

KrishanKumar1999 commented 3 months ago

You are correct but there is also an auto-approve feature by which we need not to manually approve it in CoE Admin Environment Request app. I was previously using it but now after the update of COE starter toolkit it stopped working.

Jenefer-Monroe commented 3 months ago

Can you please share a screenshot of where this settings is located? And then I'll send off to area owner.

iamaninda93 commented 3 months ago

@Jenefer-Monroe Here is the screenshot. We are using "Maker Environment" app to create an environment. After providing the necessary details in Environment maker app we are seeing the environment request is in pending state. After manual approval of this environment an environment gets created.

What we want: After providing necessary details in the maker environment app then the environment should get auto approved rather than manually approved by Admin.

MicrosoftTeams-image

Jenefer-Monroe commented 3 months ago

OK thank you, but can you clarify, is there a setting already for such things, to auto approve, or are you suggesting we add that. I'm just trying to determine if this is a bug in existing areas of the feature or if you are requesting a new feature area around auto-approval. To my knowledge this would be a new feature request but above it sounds like you found a setting where you expected this to already work.

iamaninda93 commented 3 months ago

@Jenefer-Monroe I have checked Youtube videos and found below settings might be helpful. Even after changing it “Yes” nothing helps. Auto approve of environments were working before the upgrade of CoE starter kit April version. IMG_6345

iamaninda93 commented 3 months ago

I have found a similar post here.

https://github.com/microsoft/coe-starter-kit/issues/6556

Jenefer-Monroe commented 3 months ago

OK Thank you, not a new feature then thats what I was trying to assess. To dev owner for investigation.

iamaninda93 commented 3 months ago

@Jenefer-Monroe Any update on the issue?

Jenefer-Monroe commented 3 months ago

Hello, no I do not have an update. We have assigned to the area owner and they will investigate.

iamaninda93 commented 3 months ago

Hi @Jenefer-Monroe

is there any update on the issue?

gulzarudheen commented 3 months ago

@iamaninda93 Started investigating on it.

iamaninda93 commented 3 months ago

@gulzarudheen

Any update?