search

microsoft / coe-starter-kit

Other
737 stars 216 forks source link

[CoE Starter Kit - Feature]: to many host domains for env var #8438

Open lukas-nC opened 3 months ago

lukas-nC commented 3 months ago

Is your feature request related to a problem? Please describe.

Hi, i've the problem that a tenant has to many custom domains to concatenate them for the env var (over 3000 characters)

Describe the solution you'd like

make a call via graph to get all custom domains

Describe alternatives you've considered

No response

Additional context?

No response

AB#3511

Jenefer-Monroe commented 3 months ago

Hello, do you have an example of the graph call that would be needed?

petepuu commented 3 months ago

@Jenefer-Monroe Graph call is https://graph.microsoft.com/v1.0/domains but CoE service account would need Domain.Read.All permissions for this to work.

https://learn.microsoft.com/en-us/graph/api/domain-list?view=graph-rest-1.0&tabs=http#permissions

Jenefer-Monroe commented 2 months ago

Thanks Pete! We could consider having another env var that switches though, and only calls that for folks that set it up correctly. IE something like Domains Via Env Var, (true by default)

I'm afraid with competing priorities this will sit on the backlog for a bit so if someone implements and tests, do let me know, that will make it more likely to ship soon.