search

microsoft / coe-starter-kit

Other
764 stars 225 forks source link

[ALM Accelerator - BUG]: Commit with apostrophe in "Enter Notes" box fails #8568

Open sefa-phaag opened 5 months ago

sefa-phaag commented 5 months ago

Describe the issue

If you put a comment in the Notes field when committing a solution that contains an apostrophe (for example, "don't do x..."), the solution fails to commit with the following error during the, "Saving Export Pipeline Parameters," step:

Starting: Saving Export Pipeline Parameters
==============================================================================
Task         : PowerShell
Description  : Run a PowerShell script on Linux, macOS, or Windows
Version      : 2.239.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a\_temp\fa8d69d0-0582-4c86-829d-9b8e4eaefcbb.ps1'"
ParserError: D:\a\_temp\fa8d69d0-0582-4c86-829d-9b8e4eaefcbb.ps1:9
Line |
     |                                    ~~~~~~~~~~~~~~
     | Variable reference is not valid. ':' was not followed by a valid variable name character. Consider using ${} to
     | delimit the name.
##[error]PowerShell exited with code '1'.
Finishing: Saving Export Pipeline Parameters

Expected Behavior

The apostrophe should be escaped and the commit should succeed.

What component are you experiencing the issue with?

ALM Accelerator Canvas App

What solution version are you using?

1.0.20240305.1

Steps To Reproduce

  1. In the ALM Accelerator for Power Platform app, click the Commit Solution button.
  2. In the "Enter Notes" field, enter any comment that includes an apostrophe.
  3. Click Commit Solution

Anything else?

No response

AB#3708

MaheshSripada commented 4 months ago

Thanks for reporting this. We will try to reproduce this issue and fix this.

rbass225 commented 1 month ago

We just had the exact same issue -- thank you for opening this ticket because I never would have guessed it was all down to an apostrophe!!