[ALM Accelerator - BUG]: Manual entry not saved for connection references

BeekvanV commented 3 weeks ago

Describe the issue

This might be by design, but my expectations were different.

I am working on a project on which User A does not have permissions on Downstream Environment T. He does however have Basic User permissions as to fill in the deployment configuration on Environment T. User B has prepared connections on Environment T and has given the connection Ids to User A to fill in in the deployment configuration. However when User A enters the deployment configuration for Environment T and Saves. The Manual entry for Connection to Outlook has not been saved. On selecting deployment configuration in ALM Accelerator once again. The value for the Outlook connector has emptied and shows the dropdown, which is empty because User A does not have eligible connections on Environment T. The interesting thing is. When a connector shows "Unknown" instead of "Not connected" User A was able to change the already existing value.

Things I have checked:

Looked in the settings in Admin MDA, the outlook connection was not added at all. Not the key, not the value
Removed the deployment settings to force re-create, no dice.
Used another user account with more permissions, same behavior
Looked through the Canvas App code. I found a piece of code on the "Save and Close" button which seems to check if the dropdown value has been filled out. In case of manual entry, it has not. Could this be the reason why the connector does not save?

Expected Behavior

On adding manual entries to the Connection References for them to save to the User Settings Table on selecting Save and Close.

What component are you experiencing the issue with?

ALM Accelerator Canvas App

What solution version are you using?

1.0.20240305.1

Steps To Reproduce

See video: https://github.com/user-attachments/assets/335e7bc4-7eef-4e00-a2ee-0337d007ac10

Configure deployment settings for project on which connection references have not been set.
Switch one of them to manual entry.
Change value and save and close
re-open deployment settings
manual entry was not saved.

Anything else?

No response

MaheshSripada commented 3 weeks ago

Hi @BeekvanV,

I have tried to replicate the issue in our env with manual entries, but unable to reproduce it with above mentioned steps. Deployment settings are saved correctly.

We will look into it this further. Please help us with any additional details.

BeekvanV commented 3 weeks ago

Hi @BeekvanV,

I have tried to replicate the issue in our env with manual entries, but unable to reproduce it with above mentioned steps. Deployment settings are saved correctly.

We will look into it this further. Please help us with any additional details.

Have you done so with a connection that was not owned by the user editing the Deployment settings? That might make a difference.

EDIT: I have attached a video of the OP to show the problem in a more detailed manner

Srikanth-Singapuram commented 3 weeks ago

@BeekvanV We encountered a similar issue and, as a temporary solution, we shared the connectors to the service account that is capable of managing deployments within the ALM Accelerator environment. This will enable to see the connection ID in the dropdown of the ALM Accelerator application.

BeekvanV commented 2 weeks ago

@Srikanth-Singapuram Thanks for the reply. As far as I know, connections cannot be shared with service accounts or user accounts. Only with Service principals.

Srikanth-Singapuram commented 2 weeks ago

@BeekvanV Yes, that's correct we cannot share the standard (OOTB) connectors with a Service account or user. My focus is on custom connectors and the process of creating these standard connectors within the target environment using a Service account, as well as the sharing of custom connectors with the Service account from that environment.

microsoft / coe-starter-kit