microsoft / coe-starter-kit

Other
746 stars 219 forks source link

[ALM Accelerator - BUG]: Error completing pull request (UpdatePullRequest): Deploy Solution for the Auto Complete Pull Request #9048

Open Srikanth-Singapuram opened 1 week ago

Srikanth-Singapuram commented 1 week ago

Describe the issue

I am encountering the following exception regarding the Auto Complete Pull Request (Bypass Approval) when I click on the "Deploy Solution" button for the ALM Acclerator app, which is preventing the auto-complete feature from being applied to the PR. This functionality operates correctly with the ALM Accelerator Service Account. I (with service account owner of the customAzureDevOps connector) have deleted and recreated the connection "customAzureDevOps" and shared it with the security team. The user is a member of this team; however, the same issue persists for the user.

Similer kind of exception : 6872 and 7256

Error completing pull request (UpdatePullRequest): {"$id":"1","innerException":null,"message":"Invalid argument value.\r\nParameter name: Invalid pull request auto complete set by id. Valid values are either the current user identity id, or an empty guid (to unset auto complete).","typeName":"Microsoft.TeamFoundation.SourceControl.WebServer.InvalidArgumentValueException, Microsoft.TeamFoundation.SourceControl.WebServer","typeKey":"InvalidArgumentValueException","errorCode":0,"eventId":0}

image

After "Deploy Solution" getting the exception and PR is not setting for the auto complete.

image

With the service account there is no exception and PR is setting for the autocomplete

image

Expected Behavior

The Auto Complete Pull Request (Bypass Approval) feature should function effectively for other users utilizing the same connection shared by the service account.

What component are you experiencing the issue with?

ALM Accelerator Canvas App

What solution version are you using?

1.0.20240305.1

Steps To Reproduce

No response

Anything else?

No response

Srikanth-Singapuram commented 6 days ago

@mikefactorial It appears that the problem is related to permissions, as the service account, which is an ADO Project administrator, is functioning correctly. In contrast, another user, who is part of the contributor group and possesses full access to pull requests, is experiencing issues. Could you please suggest.

ALM Accelerarot App Code : UpdatePullRequest

image

Header Request and Body for the UpdatePullRequest method.

image

It's working for service account (id: autocompleteSetBy) with all permission

image

Maker / User (id: autocompleteSetBy) with Contributor role (Repo) is getting the error.

image

Contributor Access

image

Srikanth-Singapuram commented 4 days ago

It is important to note that the user experiencing the above mentioed exception can manually enable and disable the autocomplete feature for the pull request in Azure DevOps.

MaheshSripada commented 2 days ago

Hi @Srikanth-Singapuram

Thank you for reporting this issue. We are currently reviewing the issue and will provide updates as soon as possible