search

microsoft / coe-starter-kit

Other
748 stars 221 forks source link

Envt Keep Alive - we check for states (ex PCF) for all envts, even ones excused from inventory #9169

Open Jenefer-Monroe opened 4 hours ago

Jenefer-Monroe commented 4 hours ago

Is your feature request related to a problem? Please describe.

Per https://github.com/microsoft/coe-starter-kit/issues/5968 we are using "excuse from inventory" as the temporary workaround to the keep alive problem while we await the connector solution from product team.

However we check for things like PCF before we look to see if the envt is excused.

Describe the solution you'd like

Will need to figure out the best way here. We need to check for new evnts etc... Will experiment and get this fixed for Nov

Describe alternatives you've considered

No response

Additional context?

No response

Jenefer-Monroe commented 3 hours ago

We wanted to make the most minimal change possible so we are only skipping the org check for excused environments. Here is the change. Can you please test?

  1. @outputs('Excused_From_Inventory')

Image

millsmi commented 2 hours ago

@Jenefer-Monroe I don't think this solution will work for us. We are regulated and we do get audited, so we need to provide evidence that all environments are being scanned and inventory is up to date, hygiene is the other requirement which we did recently get audited on (for Power BI this time), we can't exclude environments which are being used in the business. I hope this makes sense.

Jenefer-Monroe commented 2 hours ago

yes it does make sense. For you then, you will need to wait for the official solution from the product team in which they will grant us a way to make these calls "silently" with regards to keep alive pings.

KRhoadesHyp commented 2 hours ago

@Jenefer-Monroe I made the changes and will check back tomorrow. We have 11 environments currently excused from inventory so I will check activity dates tomorrow to see if this reflects the change. Thanks!

Jenefer-Monroe commented 2 hours ago

Thank you! I'm worried that the escalation may keep alive too but I dont think so. Then if so I'll need to sort out what to do there