microsoft / component-detection

Scans your project to determine what components you use
MIT License
428 stars 90 forks source link

Ignore leading and trailing spaces on versions #1025

Closed jcfiorenzano closed 7 months ago

jcfiorenzano commented 7 months ago

This PR addresses issue #833 . The root cause of the problem was our handling of versions, which included spaces. When creating a Python version from a string, we encountered an issue: the version passed as a parameter (including spaces) did not align with the value extracted from the regular expression (regex). The PR rectified this inconsistency, ensuring consistent version handling.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.4%. Comparing base (f85b6c4) to head (ea820f7). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1025 +/- ## ===================================== Coverage 75.4% 75.4% ===================================== Files 236 236 Lines 10407 10408 +1 Branches 1039 1039 ===================================== + Hits 7850 7851 +1 Misses 2267 2267 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂