microsoft / component-detection

Scans your project to determine what components you use
MIT License
398 stars 83 forks source link

Added optional dependency detection for npm lockfiles (version 2 and 3) #1030

Closed RushabhBhansali closed 4 months ago

RushabhBhansali commented 4 months ago

Summary:

Currently optionalDependencies in npm lockfiles are not detected by NpmLockFile3Detector and NpmDetectorWithRoots. This is fixed by this PR.

Details

Testing

Related issue: #560

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.4%. Comparing base (5be8728) to head (0b1727a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1030 +/- ## ===================================== Coverage 75.4% 75.4% ===================================== Files 236 236 Lines 10408 10409 +1 Branches 1039 1040 +1 ===================================== + Hits 7851 7852 +1 Misses 2267 2267 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RushabhBhansali commented 4 months ago

Verification test failures are expected due to addition of optional dependencies.

github-actions[bot] commented 4 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂