microsoft / component-detection

Scans your project to determine what components you use
MIT License
398 stars 83 forks source link

Evaluating invalid maven scope as "Compile" #1033

Closed RushabhBhansali closed 4 months ago

RushabhBhansali commented 4 months ago

Summary:

Currently maven detector is failing for invalid <scope> in maven dependency file. However, these dependencies are valid as per maven cli and evaluated as "Compile". Component Detector matches the maven's behavior to evaluate these "invalid" scope as "Compile"

858

Testing:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.4%. Comparing base (fb464ca) to head (3d37f1e).

Files Patch % Lines
...Detection.Detectors/maven/MavenParsingUtilities.cs 85.7% 0 Missing and 1 partial :warning:
...rs/maven/MavenStyleDependencyGraphParserService.cs 50.0% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1033 +/- ## ===================================== Coverage 75.4% 75.4% ===================================== Files 236 236 Lines 10412 10417 +5 Branches 1041 1042 +1 ===================================== + Hits 7855 7859 +4 Misses 2267 2267 - Partials 290 291 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂