microsoft / component-detection

Scans your project to determine what components you use
MIT License
396 stars 82 forks source link

Update VCPKG component identifier in detector #1046

Closed grvillic closed 3 months ago

grvillic commented 3 months ago

Updating slightly the component ID to include the origin of the VCPKG package for increased accuracy, as packages can be consumed from anywhere. This component type behaves similarly to Git components for some of their resources.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.3%. Comparing base (c06abda) to head (a8f8956).

Files Patch % Lines
...tection.Contracts/TypedComponent/VcpkgComponent.cs 85.7% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1046 +/- ## ===================================== Coverage 75.3% 75.3% ===================================== Files 237 237 Lines 10423 10429 +6 Branches 1043 1044 +1 ===================================== + Hits 7858 7863 +5 Misses 2272 2272 - Partials 293 294 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂