microsoft / component-detection

Scans your project to determine what components you use
MIT License
396 stars 81 forks source link

Update RustCli Parsing to process pkgId, and introduce manual override #1106

Closed FernandoRojo closed 1 month ago

FernandoRojo commented 1 month ago

Allows users to manually override rustCLI detector by setting an environment variable DisableRustCliScan=True

Updates cargo metadata output processing to adhere to changes introduced that make the output follow the PkgId Spec: https://doc.rust-lang.org/cargo/reference/pkgid-spec.html

Changes to the metadata output were introduced in 1.77: https://github.com/rust-lang/cargo/pull/12914

github-actions[bot] commented 1 month ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.9%. Comparing base (a513de5) to head (e24a678). Report is 7 commits behind head on main.

Files Patch % Lines
...mponentDetection.Detectors/rust/RustCliDetector.cs 89.2% 0 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1106 +/- ## ======================================= + Coverage 75.7% 75.9% +0.2% ======================================= Files 239 247 +8 Lines 10822 11089 +267 Branches 1086 1137 +51 ======================================= + Hits 8193 8419 +226 - Misses 2317 2347 +30 - Partials 312 323 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cobya commented 1 month ago

@FernandoRojo to verify, the new locations in snapshot verification are expected correct?