microsoft / component-detection

Scans your project to determine what components you use
MIT License
396 stars 81 forks source link

Update NormalizePath to handle Windows correctly #1152

Closed cobya closed 4 weeks ago

cobya commented 4 weeks ago

When running the Pip detection for setup.py files, there were extra unicode characters being added to the normalized path strings. This will fix that issue by normalizing to / which is valid on both Unix and Windows.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (393db47) to head (8ca3637). Report is 1 commits behind head on main.

Files Patch % Lines
...ft.ComponentDetection.Common/PathUtilityService.cs 50.0% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1152 +/- ## ===================================== Coverage 76.3% 76.3% ===================================== Files 255 255 Lines 11298 11338 +40 Branches 1134 1146 +12 ===================================== + Hits 8622 8661 +39 - Misses 2344 2345 +1 Partials 332 332 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 weeks ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂