microsoft / component-detection

Scans your project to determine what components you use
MIT License
396 stars 81 forks source link

Sanitize another Docker telemetry event #1164

Closed grvillic closed 3 weeks ago

grvillic commented 3 weeks ago

Context

There is another Docker event logging the docker image response which can include environment variables. We need to sanitize them to prevent logging creds pointing to feeds.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (341b036) to head (e8a0142).

Files Patch % Lines
...crosoft.ComponentDetection.Common/DockerService.cs 85.7% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1164 +/- ## ===================================== Coverage 76.3% 76.3% ===================================== Files 256 256 Lines 11329 11333 +4 Branches 1138 1138 ===================================== + Hits 8649 8653 +4 Misses 2348 2348 Partials 332 332 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂