Closed pauld-msft closed 2 weeks ago
Attention: Patch coverage is 96.29630%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 76.3%. Comparing base (
22a88b5
) to head (a694d82
).
Files | Patch % | Lines |
---|---|---|
...Orchestrator/Services/DetectorProcessingService.cs | 66.6% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like there are some parallelization issues with the GoWithReplace detector - can you take a look?
👋 Hi! It looks like you modified some files in the Detectors
folder.
You may need to bump the detector versions if any of the following scenarios apply:
devDependencies
values than beforeIf none of the above scenarios apply, feel free to ignore this comment 🙂
Looks like there are some parallelization issues with the GoWithReplace detector - can you take a look?
@cobya Yep, seems like go w/ replace was using a class level list of components, which was re-used by the different threads. Changed this up to initialize the component list as the file found method is invoked, which should make it thread safe. Also did a quick spot check and could not find similar issues with the other detectors
Adds some configurable parallelism to a single detector, e.g. within PipReport.
Added some simple pip reports that take 3-5 seconds to generate.
Running with the![image](https://github.com/microsoft/component-detection/assets/107068277/0b967e74-8942-452a-ac12-c8d43d9ebd02)
MaxDetectionThreads
set to 1:Running without the![image](https://github.com/microsoft/component-detection/assets/107068277/cb6b1dea-32ca-4d03-b663-7fb1a044e66f)
MaxDetectionThreads
(default of 10):Finally, with![image](https://github.com/microsoft/component-detection/assets/107068277/b13aaaf3-55b9-4e5c-bb72-2a3379748776)
MaxDetectionThreads
set to 2:Scan log from the 2 parallel threads is also interesting since you can see that 2 pip reports are triggered at the same time and the next set is triggered once these finish: GovCompDisc_Log_20240612152920140_41928.log