microsoft / component-detection

Scans your project to determine what components you use
MIT License
438 stars 90 forks source link

Fix bug where pipreport used index-urls from requirements.txt #1227

Closed pauld-msft closed 3 months ago

pauld-msft commented 3 months ago

Customers' pipelines are being broken because they are using file level requirements.txt index urls. This adds an option to disable those

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.5%. Comparing base (f27fe8e) to head (c61943c). Report is 1 commits behind head on main.

Files Patch % Lines
...ponentDetection.Detectors/pip/PipCommandService.cs 88.7% 5 Missing and 2 partials :warning:
...ft.ComponentDetection.Common/FileUtilityService.cs 95.2% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1227 +/- ## ===================================== Coverage 76.4% 76.5% ===================================== Files 258 258 Lines 11671 11712 +41 Branches 1180 1187 +7 ===================================== + Hits 8925 8962 +37 - Misses 2406 2409 +3 - Partials 340 341 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂

grvillic commented 3 months ago

Since this change may pick up different dependencies we might want to bump the Pip report detector's version number.