microsoft / component-detection

Scans your project to determine what components you use
MIT License
438 stars 90 forks source link

Pauldorsch/pipreport version fix #1229

Closed pauld-msft closed 3 months ago

pauld-msft commented 3 months ago

When customers build local python packages, it appears that the version doesn’t necessarily need to adhere to the python version spec. When we submit the invalid component versions to Gov service, it throws an error.

This checks for valid pip version scheme, adhering to PEP-440, before adding a package to the registrations

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.5%. Comparing base (edf0c8d) to head (49d845e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1229 +/- ## ======================================= + Coverage 75.8% 76.5% +0.6% ======================================= Files 258 258 Lines 11712 11726 +14 Branches 1187 1188 +1 ======================================= + Hits 8887 8976 +89 + Misses 2482 2409 -73 + Partials 343 341 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂