microsoft / component-detection

Scans your project to determine what components you use
MIT License
418 stars 86 forks source link

Adds supplier/license info to pip components. #938

Closed sebasgomez238 closed 8 months ago

sebasgomez238 commented 8 months ago

This only covers the default PythonResolver. This information cannot be added to the SimplePythonResolver without making additional calls which would defeat the purpose of using the SimplePythonResolver.

Classifier field specification: https://peps.python.org/pep-0301/#distutils-trove-classification and https://packaging.python.org/en/latest/specifications/core-metadata/#classifier-multiple-use

Why we prioritize License field over Classifier License field: https://packaging.python.org/en/latest/specifications/core-metadata/#license

codecov[bot] commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cf78e59) 75.1% compared to head (edcdf17) 75.2%.

Files Patch % Lines
...ft.ComponentDetection.Detectors/pip/IPyPiClient.cs 75.0% 2 Missing :warning:
...ComponentDetection.Detectors/pip/PythonResolver.cs 97.2% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #938 +/- ## ======================================= + Coverage 75.1% 75.2% +0.1% ======================================= Files 233 234 +1 Lines 10006 10052 +46 Branches 984 990 +6 ======================================= + Hits 7515 7560 +45 Misses 2220 2220 - Partials 271 272 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 8 months ago

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

If none of the above scenarios apply, feel free to ignore this comment 🙂