Closed cobya closed 7 months ago
Attention: 38 lines
in your changes are missing coverage. Please review.
Comparison is base (
b65fa8a
) 75.5% compared to head (34531b8
) 74.9%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related issue for further investigation #963
👋 Hi! It looks like you modified some files in the Detectors
folder.
You may need to bump the detector versions if any of the following scenarios apply:
devDependencies
values than beforeIf none of the above scenarios apply, feel free to ignore this comment 🙂
In the Python detectors, there are a few exceptions which are currently unhandled, leading to failures in detection which are not well presented to the user. Add some additional handling when this occurs so users have a good idea of why the error occurred and can investigate themselves to see if detection or their requirements need changes. Related issue #928
First case: Python package has multiple dependencies specified with the same package name, but differing version constraints. An exception will be hit because of the
ToDictionary
call which expects distinct values.I'll be filing an issue here for further investigation, but for now, choose the latest specifier given to avoid skipping the dependency all together.
Second case: Python package is given version constraints either from requirements.txt or package dependency version specifiers which are not resolved in PyPi. Previously only the package name was outputted to the user, meaning they don't know why a valid version wasn't found if the package exists on PyPi.